Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Transaction Hashing #25

Closed
davecgh opened this issue Oct 26, 2013 · 1 comment
Closed

Optimize Transaction Hashing #25

davecgh opened this issue Oct 26, 2013 · 1 comment
Labels
optimization

Comments

@davecgh
Copy link
Member

davecgh commented Oct 26, 2013

Profiling has shown that transaction hashing is a reasonable candidate for optimization as it is currently takes around 6% of the block handling time. Since hashing is such a large part of block and transaction handling, this is not all that unexpected. However, there are various cases where a transaction is hashed more than once instead of using the cached version to avoid recomputing it.
davecgh added a commit to btcsuite/btcdb that referenced this issue Oct 27, 2013
@davecgh
Optimize InsertBlock with cached tx hashes.
19880b1 
This commit optimizes InsertBlock slightly by using the cached transaction
hashes instead of recomputing them.  Also, while here, use the
ShaHash.IsEqual function to do comparisons for consistency.

This is ongoing work towards btcsuite/btcd#25.

ok @drahn.
davecgh added a commit to btcsuite/btcutil that referenced this issue Oct 27, 2013
@davecgh
Add new Tx wrapper for btcwire.MsgTx.
e402c62 
Currently, transaction hash caching is provided via Block directly, but a
transaction is not always part of a block and there are several cases
where only the transaction needs to be dealt with without wanting to pass
the entire block and transaction index around to be able to get at the
cached hash.

So, this commit adds a new type named Tx which is a wrapper that provides
easier and more efficient manipulation of raw wire protocol transactions.
It memoizes the hash for the transaction on its first access so subsequent
accesses don't have to repeat the relatively expensive hashing operations.
The idea is the callers can pass around pointers to these Tx types instead
of raw btcwire.MsgTx pointers.

For now, the Block API has not been changed, but the plan is to change it
to provide access to these wrapped transactions rather than having it do
the transaction hash caching directly.

This is only the first part of a series of changes working towards
optimizations noted in btcsuite/btcd#25.
davecgh added a commit to btcsuite/btcutil that referenced this issue Oct 27, 2013
@davecgh
Add tests for new Tx type.
29f1bf4 
This commit adds both positive and negative tests for the new Tx type to
bring its coverage to 100%.

This is part of the ongoing transaction hash optimization effort noted
in btcsuite/btcd#25.
davecgh added a commit to btcsuite/btcutil that referenced this issue Oct 28, 2013
@davecgh
Add funcs to Block API for wrapped transactions.
8e97f32 
This commit adds two new functions to the Block API for working with the
recently added Tx type from the Block.

These new functions are named Tx and Transactions.  Tx returns a
transactions for the specified index as a Tx and also memoizes it so
subsequent calls are more efficient.  Transactions returns a slice of all
transactions in the Block wrapped in a Tx.

This is part of the ongoing transaction hash optimization effort
noted in btcsuite/btcd#25.
davecgh added a commit to btcsuite/btcutil that referenced this issue Oct 28, 2013
@davecgh
Add tests for new Block API functions.
93e46b9 
This commit adds both positive and negative tests for the new Tx and
Transactions Block API functions.

This is part of the ongoing transaction hash optimization effort noted in
btcsuite/btcd#25.
davecgh added a commit to btcsuite/btcchain that referenced this issue Oct 28, 2013
@davecgh
Convert API to use new btcutil.Tx.
6165e9b 
This is part of the ongoing transaction hash optimization effort noted in
btcsuite/btcd#25.
davecgh added a commit that referenced this issue Oct 28, 2013
@davecgh
Convert to use new btcutil.Tx and btcchain APIs.
08fc305 
This commit updates btcd to work with the new btcchain APIs which now
accept btcutil.Tx instead of raw btcwire.MsgTx.  It also modifies the
transaction memory pool to store btcutil.Tx.

This is part of the ongoing transaction hash optimization effort noted in
#25.
@davecgh
Copy link
Member Author

davecgh commented Oct 29, 2013

This has been completed as of commit 08fc305.

@davecgh davecgh closed this as completed Oct 29, 2013
@davecgh davecgh mentioned this issue Oct 30, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
optimization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davecgh