Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mining: return witness_script instead of raw witness_commitment in GBT #1807

Conversation

roylee17
Copy link
Contributor

@roylee17 roylee17 commented Feb 8, 2022

The "default_witness_commit" in the getblocktemplate response uses the witness_script instead of raw commitment.

@coveralls
Copy link

coveralls commented Feb 8, 2022

Pull Request Test Coverage Report for Build 1850844731

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.676%

Totals Coverage Status
Change from base Build 1808348675: 0.0%
Covered Lines: 1231
Relevant Lines: 1545

💛 - Coveralls

@roylee17
Copy link
Contributor Author

roylee17 commented Feb 9, 2022

@Roasbeef

@Roasbeef
Copy link
Member

@roylee17 slipped by initial due to a lack of integration tests in this area. Would you mind adding a new test in the integration folder? It would use GBT to construct a new block and then assert that we also accept that same block.

@roylee17 roylee17 closed this Feb 16, 2022
@roylee17 roylee17 deleted the roylee/update-gbt-to-return-witness-script branch February 16, 2022 03:47
@roylee17 roylee17 restored the roylee/update-gbt-to-return-witness-script branch February 16, 2022 03:48
@roylee17 roylee17 reopened this Feb 16, 2022
@roylee17
Copy link
Contributor Author

[Accidentally deleted the branch, which generates the, PR.]

@Roasbeef I'll look into how to create that test.

@roylee17 roylee17 closed this Sep 2, 2022
@roylee17 roylee17 deleted the roylee/update-gbt-to-return-witness-script branch September 2, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants