Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi: remove repetitive the #1998

Merged
merged 1 commit into from
Jun 26, 2023
Merged

multi: remove repetitive the #1998

merged 1 commit into from
Jun 26, 2023

Conversation

cuishuang
Copy link
Contributor

No description provided.

@kcalvinalvin
Copy link
Collaborator

Could you change the commit message to:

multi: remove repetitive the

LGTM otherwise

@cuishuang
multi: remove repetitive the
e160bb6 
Signed-off-by: cui fliter <imcusg@gmail.com>
@cuishuang cuishuang changed the title remove repetitive the multi: remove repetitive the Jun 26, 2023
@cuishuang
Copy link
Contributor Author

Could you change the commit message to:

multi: remove repetitive the

LGTM otherwise

Of course. Done

halseth
halseth approved these changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@halseth halseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kcalvinalvin
Copy link
Collaborator

Seems like that one test that occasionally fails is failing.

I can't run the CI again but you could trigger the CI by an empty

git commit --amend and change the commit hash.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5375193722

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 55.228%
Files with Coverage Reduction New Missed Lines %
connmgr/connmanager.go 3 86.27%
Totals Coverage Status
Change from base Build 5342979571: 0.002%
Covered Lines: 26648
Relevant Lines: 48251
💛 - Coveralls

@guggero
Copy link
Collaborator

guggero commented Jun 26, 2023

Can confirm the CI failure was a flake.

@guggero guggero merged commit f9cbff0 into btcsuite:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halseth halseth halseth approved these changes

@guggero guggero guggero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cuishuang @kcalvinalvin @coveralls @guggero @halseth