Add Browser Support (Neutrino) #2124
Conversation
| @@ -23,6 +23,11 @@ func appDataDir(goos, appName string, roaming bool) string { | |||
| return "." | |||
| } | |||
|
|
|||
| // Fallback to an empty string on js since we do not have a file system. | |||
| if goos == "js" { | |||
There was a problem hiding this comment.
Does this case need to be handled elsewhere in practice?
| @@ -27,11 +27,21 @@ import ( | |||
| "github.com/btcsuite/btcd/wire" | |||
| ) | |||
|
|
|||
| var ErrNotExist = errors.New("store does not exist") | |||
|
|
|||
| // store is a basic storage interface. Either using the file system or localStorage in the browser. | |||
There was a problem hiding this comment.
godoc string should be wrapped to 80 char columns
| @@ -27,11 +27,21 @@ import ( | |||
| "github.com/btcsuite/btcd/wire" | |||
| ) | |||
|
|
|||
| var ErrNotExist = errors.New("store does not exist") | |||
| @@ -1206,7 +1213,7 @@ func (a *AddrManager) GetBestLocalAddress(remoteAddr *wire.NetAddressV2) *wire.N | |||
| // Use Start to begin processing asynchronous address updates. | |||
| func New(dataDir string, lookupFunc func(string) ([]net.IP, error)) *AddrManager { | |||
| am := AddrManager{ | |||
| peersFile: filepath.Join(dataDir, "peers.json"), | |||
| store: NewStore(filepath.Join(dataDir, "peers.json")), | |||
There was a problem hiding this comment.
Should the store also be accepted as an optional argument so it can be properly initialized in the WASM/browser context?
There was a problem hiding this comment.
Ah scratch that, I see the build tag usage below!
| "os" | ||
| ) | ||
|
|
||
| type Store struct { |
| buf := bytes.NewBufferString(val) | ||
|
|
||
| // Create a NOP closer, we have nothing to do upon close. | ||
| return io.NopCloser(buf), nil |
| @@ -14,6 +14,7 @@ require ( | |||
| github.com/gorilla/websocket v1.5.0 | |||
| github.com/jessevdk/go-flags v1.4.0 | |||
| github.com/jrick/logrotate v1.0.0 | |||
| github.com/linden/localstorage v0.0.0-20231117043609-5d94f0a86609 | |||
There was a problem hiding this comment.
Perhaps we can just fold in the code into the project so we don't need to add a new extertnal dep? It could live in an internal package.
I checked it out, and looks like a pretty minimal set of helper funcs.
|
Approved the CI run. We should also add a new CI target to build w/ the |
| @@ -62,4 +63,4 @@ retract ( | |||
| v0.13.0-beta | |||
| ) | |||
|
|
|||
| go 1.17 | |||
| go 1.21.2 | |||
There was a problem hiding this comment.
IIRC go.mod doesn't handle minor version specification
|
closing, same reason as lightninglabs/neutrino#295 (comment). |
Minor changes needed to accommodate Neutrino in the browser (lightninglabs/neutrino#295).