txscript: Increase maximum allowed nulldata bytes #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -303,7 +307,8 @@ func isMultiSig(pops []parsedOpcode) bool { | |||
| // false otherwise. | |||
| func isNullData(pops []parsedOpcode) bool { | |||
| // A nulldata transaction is either a single OP_RETURN or an | |||
| // OP_RETURN SMALLDATA (where SMALLDATA is a push data up to 40 bytes). | |||
| // OP_RETURN SMALLDATA (where SMALLDATA is a push data up to | |||
| // maxDataCarrierSize bytes. | |||
There was a problem hiding this comment.
Looks like this is missing the ) before the period.
|
OK once the minor ) typo is fixed. |
This change increases the maximum allowed bytes allowed in pushed data to be considered a nulldata transaction. This matches the current value the reference implementation uses by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change increases the maximum allowed bytes allowed in pushed
data to be considered a nulldata transaction. This matches the current
value the reference implementation uses by default.