Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data directory short option should be '-b'. #339

Closed
jrick opened this issue Dec 9, 2015 · 0 comments
Closed

Data directory short option should be '-b'. #339

jrick opened this issue Dec 9, 2015 · 0 comments

Comments

@jrick
Copy link
Member

jrick commented Dec 9, 2015

This matches the rest of the btcsuite tools.

spotted by @davecgh while reviewing #337.

jrick added a commit to jrick/btcwallet that referenced this issue Feb 1, 2016
jrick added a commit to jrick/btcwallet that referenced this issue Feb 1, 2016
jrick added a commit to jrick/btcwallet that referenced this issue Oct 4, 2016
This is a step towards completing btcsuite#315.

This changes the database access APIs and each of the "manager"
packages (waddrmgr/wtxmgr/wstakemgr) so that transactions are
opened (only) by the wallet package and the namespace buckets
that each manager expects to operate on are passed in as
parameters.

This helps improve the atomicity situation as it means that many
calls to these APIs can be grouped together into a single
database transaction.

This change does not attempt to completely fix
the "half-processed" block problem. Mined transactions are still
added to the wallet database under their own database transaction
as this is how they are notified by the consensus JSON-RPC
server (as loose transactions, without the rest of the block that
contains them). It will make updating to a fixed notification
model significantly easier, as the same "manager" APIs can still
be used, but grouped into a single atomic transaction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant