Update btcd dependency, add Signet params #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpaulino
reviewed
Mar 5, 2021
There was a problem hiding this comment.
LGTM, travis is failing with:
--- FAIL: TestRPCMethodHelpGeneration (0.01s)
rpchelp_test.go:59: Cannot generate 'en_US' help for method 'listsinceblock': missing description for 'listtransactionsresult-label'
rpchelp_test.go:59: Cannot generate 'en_US' help for method 'listtransactions': missing description for 'listtransactionsresult-label'
rpchelp_test.go:59: Cannot generate 'en_US' help for method 'listaddresstransactions': missing description for 'listtransactionsresult-label'
rpchelp_test.go:59: Cannot generate 'en_US' help for method 'listalltransactions': missing description for 'listtransactionsresult-label'
rpchelp_test.go:46: Regenerate help texts with 'go generate' after fixing
|
Fixed Travis. |
|
Rebased. @Roasbeef PTAL. |
wpaulino
reviewed
Apr 26, 2021
With this commit we add the signet test network parameters to all switch cases where we distinguish between the different networks.
|
Rebased and added a few more cases that were previously not covered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for lightningnetwork/lnd#5025.
Depends on btcsuite/btcd#1692.
Adds support for Bitcoin Signet.
cc @Roasbeef, @wpaulino.