Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Crud operations #13

Closed
wants to merge 3 commits into from
Closed

Added Crud operations #13

wants to merge 3 commits into from

Conversation

elliott-davis
Copy link

Added Crud operations to the socket. I don't know if you want this in the core code. I added it to so this module could work with SailsJS.

Added get, post, put and delete operations to socket wrapper
MUST include sails.io.js file for this to work.
@btford
Copy link
Owner

btford commented Jul 26, 2013

Please rebase against master. 004ea33 and 4c04c5f are stale.

@btford
Copy link
Owner

btford commented Jul 26, 2013

Actually, I think this should be a separate module on top of angular-socket-io. You could do something like:

angular.module('libsysguy.socket-io-crud', [
  'btford.socket-io'
]).
factory('crudSocket', function (socket) {
  var crudSocket = {};

  // add methods to crudSocket using socket

  return crudSocket;
});

This keeps the code modular and doesn't bring in dead code for users of angular-socket-io.

If you think the code is helpful to others, you can put it up on Bower as well.

@btford
Copy link
Owner

btford commented Mar 3, 2014

See #33 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants