Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #19 - Add support for source-map generation #51

Closed
wants to merge 2 commits into from

Conversation

caitp
Copy link

@caitp caitp commented Sep 21, 2013

The generated sourcemap is not very helpful as of yet, but I'm working on that. I think this is probably a better solution than the alternative method attempted earlier :)

The astral-angular-annotate module will need to be updated to update the locations of items, I think. But it's sort of difficult to work out how it's intended to actually work.

I don't know how this will work with source-map chaining as of yet, that is a more involved test, I'll do more of that once it's a bit further along I suppose.

@caitp caitp mentioned this pull request Sep 21, 2013
@caitp
Copy link
Author

caitp commented Sep 21, 2013

So, this -sort of- works, in my tests... But I think the line numbering is all screwy still, I'm not totally sure how hard it will be to fix that. The mappings are not really "accurate". :(

I'll probably need to study other implementations, such as those in coffee-script, to figure out how to do this better.

@olanod
Copy link

olanod commented Sep 26, 2013

+1, check UglifyJs2 which allows specifying an input .map file. It would be cool to have my final source map reference my original coffee files after ngmining and uglifying.

@btford
Copy link
Owner

btford commented Oct 21, 2013

Sorry for the late reply on this

I'd love to have sourcemap support, but I'm thinking the best way would be to have an overarching build system that handles it. This is my intention with Astral, but that project has a ways to go.

In the mean time, I'm happy to accept this if/when you get it working. :)

@cparker15
Copy link

Any progress, @caitp? I'm in the same position as @olanod.

Happy to help.

@caitp
Copy link
Author

caitp commented Oct 21, 2013

Well the mechanics for it (I think) are pretty much in place, but a remaining piece is to add the source map locations for each generated symbol in astral-angular-annotate, and that would take more time than I really have to put into it at the moment :(

If someone else writes a patch to hack that stuff into the annotate component, it should be pretty much there. The downside to the super-modular structure is that writing a test suite for the changes is a bit tricky, and because of that I'm not super confident in the code I'd write

@NickHeiner
Copy link

👍 This would be super useful for me and my team.

@qraynaud
Copy link

Same here !

@mgol
Copy link

mgol commented Jul 22, 2014

@qraynaud

Same here !

This module is no longer maintained; see olov/ng-annotate#49 for the source map issue in ng-annotate.

@eddiemonge eddiemonge closed this Aug 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants