Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test search by file name function #31

Merged
merged 9 commits into from
Oct 13, 2017
Merged

Conversation

gatukgl
Copy link
Contributor

@gatukgl gatukgl commented Oct 10, 2017

  • I've renamed test assets at the root directory from images to be test-assets and also added some images there.

  • I've added jest to run unit tests for .search() in index.js. So now we can use a command $ yarn test:jest to run unit tests.

  • For the index.js, to run unit tests against this file. I've checked running environment if there's test environment, we could just interested in .search() or .format()

**This PR includes just the tests for .search(). I'll added another PR for .format() if it's done.

If there's any question. Feel free to ask me. :)

connected to #12

@gatukgl
Copy link
Contributor Author

gatukgl commented Oct 10, 2017

This PR includes just the tests for .search(). I'll added another PR for .format() if it's done. :D

@btk btk merged commit f30865b into btk:master Oct 13, 2017
@btk
Copy link
Owner

btk commented Oct 13, 2017

Hey @gatukgl this is great. I merged this and added babel presets to package.json also changed the npm script tags. And added info about how to use test scripts, see current master.

Thank you!

@btk btk mentioned this pull request Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants