-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of Python 3.7+ #165
Conversation
@@ -22,7 +22,7 @@ class Cache: | |||
cache_dir = get_app_dir("twtxt") | |||
cache_name = "cache" | |||
|
|||
def __init__(self, cache_file, cache, update_interval): | |||
def __init__(self, cache_file, cache, update_interval=0): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #141
61f3ede
to
9f58c95
Compare
@buckket, do you have some plans about releasing version 1.3.0? |
This is stopping me installing and using twtxt, would love a merge |
You may install this version from a local directory. You need to have git clone https://github.com/win0err/twtxt.git
cd twtxt/
git checkout feature/python-3-7-plus
pip install -e . |
Hmm I installed following your instructions but get this error when trying to run quickstart
|
|
@KAction, thank you, I've merged your changes to my fork. @ChildishGiant, please, run |
14d9418
to
9f58c95
Compare
* Import "get_terminal_size" from "shutil", not "click"
Thanks! I’ve modified the code slightly to work without nest_asyncio. |
Problem: Generator-based coroutines are deprecated and scheduled for removal in Python 3.11 (docs). Due to that, twtxt doesn't work with Python 3.7+.
Solution: I have changed gererator-based coroutines to async-def coroutines. Other dependencies have also been updated to current versions.
Important: breaking changes, won't work with Python 3.6 or lower.
Passed tests: https://github.com/win0err/twtxt/actions/runs/2009500872
I'll create a PR with integration with GitHub Actions in a separate PR.
Closes #140, closes #141, closes #161, closes #162, closes #163
P.S. Please, test the changes manually.