Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --since option for timeline and view cli command #83

Merged
merged 1 commit into from
Mar 2, 2016

Conversation

timofurrer
Copy link
Contributor

Support --since option in timeline and view cli command.
The dateparser package is used to parse the since date: https://pypi.python.org/pypi/dateparser

Examples:

twtxt timeline --since yesterday
twtxt timeline --since "1 hour ago"
twtxt view --since "Fri, 12 Dec 2014 10:55:50"

@timofurrer
Copy link
Contributor Author

Any concerns about this one?

buckket added a commit that referenced this pull request Mar 2, 2016
Support --since option for timeline and view cli command
@buckket buckket merged commit 8080d11 into buckket:master Mar 2, 2016
@buckket
Copy link
Owner

buckket commented Mar 2, 2016

Had to revert this as dateparser has some problems with it’s setup.py that breaks stuff on RTD (UnicodeDecodeError), for example. We also would incorporate many new dependencies, will think about our possibilities here :/

@timofurrer
Copy link
Contributor Author

oh, shit .. I'll figure something out asap.

Is it possible to reopen this PR?

@timofurrer
Copy link
Contributor Author

Could you open an issue at the dateparser repo about that?

@buckket
Copy link
Owner

buckket commented Mar 3, 2016

Apparently it’s not possible to reopen a merged PR. Will double check if the error is really caused by dateparser, i.e. if they should change something rather than say RTD.

@timofurrer
Copy link
Contributor Author

Okay, thanks. Are you fine if I submit the PR again and mark it as WIP?
To discuss further steps there and that no other person is working on the related issue..

@buckket
Copy link
Owner

buckket commented Mar 3, 2016

Sure, go ahead! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants