Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled b-select and b-input have different colors #2599

Closed
miraculli opened this issue Jun 13, 2020 · 3 comments · Fixed by #2665
Closed

Disabled b-select and b-input have different colors #2599

miraculli opened this issue Jun 13, 2020 · 3 comments · Fixed by #2665

Comments

@miraculli
Copy link

Overview of the problem

Buefy version: [0.8.20]
Vuejs version: [2.6.11]
OS/Browser: macOS 10.15.5 / Chrome 83.0.4103.97

Description

Bildschirmfoto 2020-06-13 um 12 39 56

When I make use of different form-fields like b-input and b-select as disabled they don't look exactly the same and the disabled b-input is (much) harder to read than a disabled b-select.

Steps to reproduce

<b-field label="Target" label-position="on-border">
  <b-select v-model="sink" disabled>
    <option value="AAA"> AAA</option>
    <option value="BBB">BBB</option>
    <option value="CCC">CCC</option>
  </b-select>
</b-field>

<b-field label="Titel" label-position="on-border">
  <b-input disabled placeholder="Lorem Ipsum"></b-input>
</b-field>

Expected behavior

Disabled fields use the same colors, grey-tones

Actual behavior

Disabled fields don't use the same colors, grey-tones.

@service-paradis
Copy link
Collaborator

You're right. It not directly related to Buefy nor Bulma. It is the browser default styles as you can see in this example:
https://codepen.io/service-paradis/pen/ZEQRzad?editable=true

In this case, Chrome apply opacity: 0.7 for disabled select element. No opacity is set for disabled input.

Maybe, it is worth opening an issue at Bulma for this. There are 2 easy solutions for this:

  1. Force opacity: 1 for disabled select
  2. Force opacity: 0.7 for disabled input

We can ask @jtommy if he want to apply this fix in the Buefy codebase.

@jtommy
Copy link
Member

jtommy commented Jul 10, 2020

@service-paradis yes we can add in Buefy codebase. As you want for 1 o 2 solution :)

service-paradis added a commit to service-paradis/buefy that referenced this issue Jul 10, 2020
jtommy pushed a commit that referenced this issue Jul 10, 2020
@kashifusman
Copy link

I am still having the issue on IOS/Safari the select and input have different font color.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants