Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When moving through dates using the arrow keys, the focus is lost #2683

Closed
tomearly opened this issue Jul 16, 2020 · 3 comments · Fixed by #2691 or #2922
Closed

When moving through dates using the arrow keys, the focus is lost #2683

tomearly opened this issue Jul 16, 2020 · 3 comments · Fixed by #2691 or #2922
Labels
feature request

Comments

@tomearly
Copy link

tomearly commented Jul 16, 2020 •
edited
Loading

Description

When moving through dates using the arrow keys, the focus is lost:

Video

a11y-lost-focus.mp4.zip

Why Buefy need this feature

This will better enable users with accessibility needs to use the datepicker.
@service-paradis
Copy link
Collaborator

As a gif to view the behavior more easily:
a11y-lost-focus

service-paradis added a commit to service-paradis/buefy that referenced this issue Jul 20, 2020
@service-paradis
Fix buefy#2683
94a02c5 
- Condition needed to be in $nextTick when changing month using arrows
@service-paradis service-paradis mentioned this issue Jul 20, 2020
Merged
jtommy pushed a commit that referenced this issue Jul 20, 2020
@service-paradis
Fix #2683 (#2691)
917c9ff 
* Fix #2683

- Condition needed to be in $nextTick when changing month using arrows

* Remove unneeded console
@cristinutza2k
Copy link

Hi,
The focus problem persists, here is the example I refer to: https://codepen.io/cristinutza2k/pen/LYNqOvy?editors=1010
Everything works fine except for the case where you have the option to select days from other months, then everything gets crazy with the focus state.

@service-paradis
Copy link
Collaborator

The problem is kind of different this time. It is more related to unselectable-days-of-week. This props is not taken into account right now when using the arrow keys...

service-paradis added a commit to service-paradis/buefy that referenced this issue Sep 24, 2020
@service-paradis
Fix buefy#2683 again
a3d06ac 
- Use month in ref name to prevent duplicate references
- When using arrow keys, jump over unselected dates
@service-paradis service-paradis mentioned this issue Sep 24, 2020
Merged
jtommy pushed a commit that referenced this issue Sep 24, 2020
@service-paradis
Fix #2683 again (#2922)
cc2c54c
WTDuck pushed a commit to ProovGroup/buefy that referenced this issue Jan 8, 2021
@service-paradis @WTDuck
Fix buefy#2683 again (buefy#2922)
b946802
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2683 service-paradis/buefy
Fix #2683 again service-paradis/buefy
3 participants
@tomearly @cristinutza2k @service-paradis