Making TagInput's Tag content customisable #2209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #2209 +/- ##
=======================================
Coverage 65.14% 65.14%
=======================================
Files 70 70
Lines 2645 2645
Branches 868 868
=======================================
Hits 1723 1723
Misses 849 849
Partials 73 73
Continue to review full report at Codecov.
|
jacobgoh101
requested review from
rafaberaldo and
jtommy
and removed request for
rafaberaldo
jtommy
requested changes
Feb 7, 2020
src/components/taginput/Taginput.vue
Outdated
| {{ getNormalizedTagText(tag) }} | ||
| <slot | ||
| name="tag" | ||
| :text="getNormalizedTagText(tag)" |
There was a problem hiding this comment.
In this case I think we might remove :text because there is already tag parameter
There was a problem hiding this comment.
I've removed it in the latest commit.
… be retrievable using the `tag` prop.
|
@jacobgoh101 thanks ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referring to #2208
Proposed Changes