Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Added Breadcrumb component #3464

Merged
merged 23 commits into from
Sep 18, 2021

Conversation

mouadTaoussi
Copy link
Contributor

Fixes #3294

New feature

Since many UI frameworks provides breadcrumb in their project why not making it for buefy? after that new component for breadcrumb to buefy! has been implemented and waiting for review and merge.

Note: If any required changes are needed I'm gonna be glad to work on them!

Checklist

  • Respected all the buefy contributing guidelines.
  • Wrote and ran the tests for it, all of them are PASSED.
  • Tested the feature in different browsers.
  • Tested the feature in different screen sizes.

Upcoming Features

  • Icons for each item in breadcrumb.

Why buefy needs that feature?

  • Base CSS framework that buefy builts on has breadcrumb in components side.
  • Helps visitors locates where they are while they navigate. flexible navigation!

Thank You!

@mouadTaoussi mouadTaoussi changed the title Added Breadcrumb component [Feature Request]: Added Breadcrumb component Aug 17, 2021
@jtommy jtommy self-requested a review August 24, 2021 06:47
src/components/breadcrumb/Breadcrumb.vue Outdated Show resolved Hide resolved
src/components/breadcrumb/Breadcrumb.vue Outdated Show resolved Hide resolved
src/scss/buefy.scss Outdated Show resolved Hide resolved
src/components/breadcrumb/Breadcrumb.vue Outdated Show resolved Hide resolved
@mouadTaoussi
Copy link
Contributor Author

@jtommy

src/components/breadcrumb/Breadcrumb.vue Outdated Show resolved Hide resolved
@mouadTaoussi
Copy link
Contributor Author

Now you can re-review it.

@jtommy jtommy merged commit 48aa1dc into buefy:dev Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New component for Breadcrumbs
2 participants