Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(events): Add event support for resources and controllers. #132

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

buehler
Copy link
Owner

@buehler buehler commented Jan 19, 2021

This closes #5.

The provided IEventManager helps with publishing
singleton events (fire and forget) and event series.
The event-name is deterministic, so if the same event
is published multiple times, an event series is created
(when used with Publish(string,string...)).

/cc @ocdi

@buehler
Copy link
Owner Author

buehler commented Jan 19, 2021

@tomkerkhove If you like, you can do a little review here :-)
What do you think about the "general" API that the IEventManager provides?

@buehler
Copy link
Owner Author

buehler commented Jan 19, 2021

Hey @tomkerkhove. Sadly, I can't assign you to the pull request. So I'd request it via "comment".

Copy link
Contributor

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few questions.

src/KubeOps/Operator/Events/EventManager.cs Show resolved Hide resolved
src/KubeOps/Operator/Events/EventManager.cs Show resolved Hide resolved
@buehler
Copy link
Owner Author

buehler commented Jan 19, 2021

Perfect, thanks for your help!
I'm writing some tests for it and then I'm going to merge it.

This closes #5.

The provided IEventManager helps with publishing
singleton events (fire and forget) and event series.
The event-name is deterministic, so if the same event
is published multiple times, an event series is created
(when used with Publish(string,string...)).

Signed-off-by: Christoph Bühler <christoph@smartive.ch>
@buehler buehler enabled auto-merge (squash) January 19, 2021 18:31
@buehler buehler merged commit 3537772 into master Jan 19, 2021
@buehler buehler deleted the feat/event-support branch January 19, 2021 18:38
@github-actions
Copy link

🎉 This PR is included in version 3.0.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Feb 8, 2021

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add easy mechanism for "events" (kubernetes object events)
2 participants