-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Merge Watch & Local events. Switch by uid & type grouping. #616
[Feat] Merge Watch & Local events. Switch by uid & type grouping. #616
Conversation
These changes were tested on a private prod like cluster. Performed tests are the following:
|
Watcher and Local events are now merged to produce a sequence containing all captured events instead of just the sequence that was last produced. Events will still be switch but only at group level, grouping by resource Uid and sub-grouping by event type, therefore Keeping alway last event for each type of each resources, preventing events accumulation.
fdc810d
to
a362ba5
Compare
Thank you @Crespalvaro for the contribution! When I'm more or less ready with v8 (on the default branch), I very much like your opinion on it :-) |
Whoops, there are some errors in testing, can you please fix these and commit again? The tests should automatically run as far as I know. |
@buehler You can count with it! Ill give it a check once you have it ready. Apologizes, I did not update Test, let me put my hands on it |
Should be good now. I believe it stills requires your approval @buehler |
@Crespalvaro if you have some spare time, you can test the v8 version now. There is a general usage documentation in the respective readmes. The Generator package can provide you with convenience functions. |
@buehler Thanks for letting me know. I'm right about to finish a big delivery for my project, therefore I expect to have some spare time to dedicate to such testing soon. I'll be coming back to you with my feedback |
Watcher and Local events are now merged to produce a sequence containing all captured events instead of just the sequence that was last produced. Events will still be switch but only at group level, grouping by resource Uid and sub-grouping by event type, therefore Keeping alway last event for each type of each resources, preventing events accumulation.
Fixes #585 #579