Add KPrintfMessageParser & KDefaultPrintfMessageParser #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lemented yet and would fail)
buenaflor
commented
Aug 4, 2023
| @@ -79,7 +79,7 @@ static String getSafeSystemNewline() { | |||
| * @param formatStart the index of the (first) format character in the term. | |||
| * @return the index after the last character of the term. | |||
| */ | |||
| abstract int parsePrintfTerm( | |||
| protected abstract int parsePrintfTerm( | |||
There was a problem hiding this comment.
Small change to the Java Flogger codebase
There was a problem hiding this comment.
This change makes sense. In an ideal world it would make sense to make this internal so that this is only accessible to friend modules.
MarkCMann
approved these changes
Aug 8, 2023
| @@ -79,7 +79,7 @@ static String getSafeSystemNewline() { | |||
| * @param formatStart the index of the (first) format character in the term. | |||
| * @return the index after the last character of the term. | |||
| */ | |||
| abstract int parsePrintfTerm( | |||
| protected abstract int parsePrintfTerm( | |||
There was a problem hiding this comment.
This change makes sense. In an ideal world it would make sense to make this internal so that this is only accessible to friend modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I tried my best not to touch the Java Flogger code but I couldn't find any other way to solve the following issue:
PrintfMessageParsercontains the functionabstract int parsePrintfTermwhich I cannot override in Kotlin modules because the Java visibility is package-private. So the only solution I found was to increase the visibility toprotected.@MarkCMann