This repository has been archived by the owner on Feb 13, 2023. It is now read-only.
E2E fixes #25
Merged
E2E fixes #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistuulNG
approved these changes
Jun 8, 2022
tonistuulNG
reviewed
Jun 8, 2022
2 tasks
added 2 commits
June 8, 2022 17:15
guypritchard
commented
Jun 8, 2022
decodingahmed
approved these changes
Jun 8, 2022
martinkearn
approved these changes
Jun 9, 2022
Minimum allowed line rate is |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a list of changes I made to get the E2E demo working.
There's something not quite right about the PostMessageAsync method of the chat controller. The original input type was a string - but there were some escaping issues so I fell back on a content scraping approach to get things 'working'. Should this message have a concrete type? Something feels off here.
I added some logging to display the DMR callback messages for the demo, but could be useful for people running locally until we have some actual code doing things with the messages.
I also added the capability to run multiple bots by setting a name in configuration.
...and a few tests.
Look at this one carefully - it was a bit hack and slash to get this going.