Improve private/buf/dag #2240
Merged
Improve private/buf/dag #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doriable
approved these changes
Jun 29, 2023
joshcarp
reviewed
Jun 29, 2023
| @@ -195,6 +241,34 @@ func (g *Graph[Key]) DOTString(keyToString func(Key) string) (string, error) { | |||
| ); err != nil { | |||
| return "", err | |||
| } | |||
| // We also want to pick up any nodes that do not have edges, and display them. | |||
| if err := g.WalkNodes( | |||
| func(key Key, inboundEdges []Key, outboundEdges []Key) error { | |||
There was a problem hiding this comment.
Suggested change
| func(key Key, inboundEdges []Key, outboundEdges []Key) error { | |
| func(key Key, inboundEdges, outboundEdges []Key) error { |
| // We also want to pick up any nodes that do not have edges, and display them. | ||
| if err := g.WalkNodes( | ||
| func(key Key, inboundEdges []Key, outboundEdges []Key) error { | ||
| // |
| @@ -180,9 +180,9 @@ func TestWalk2(t *testing.T) { | |||
| ) | |||
| } | |||
|
|
|||
| func TestWalk3(t *testing.T) { | |||
| func TestWalkEdges3(t *testing.T) { | |||
There was a problem hiding this comment.
nit: test names should be more descriptive instead of Test<Num>
Comment on lines
+137
to
+141
| // f is called for each directed edge. The first argument is the source | ||
| // node, the second is the destination node. | ||
| // | ||
| // Returns a *CycleError if there is a cycle in the graph. | ||
| func (g *Graph[Key]) Walk(f func(Key, Key) error) error { | ||
| func (g *Graph[Key]) WalkEdges(f func(Key, Key) error) error { |
There was a problem hiding this comment.
This could be in the func signature instead of the doc
Suggested change
| // f is called for each directed edge. The first argument is the source | |
| // node, the second is the destination node. | |
| // | |
| // Returns a *CycleError if there is a cycle in the graph. | |
| func (g *Graph[Key]) Walk(f func(Key, Key) error) error { | |
| func (g *Graph[Key]) WalkEdges(f func(Key, Key) error) error { | |
| // f is called for each directed edge. | |
| // | |
| // Returns a *CycleError if there is a cycle in the graph. | |
| func (g *Graph[Key]) WalkEdges(f func(sourceNode Key, destinationNode Key) error) error { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NumNodesto return the number of nodes.NumEdgesto return the number of edges.WalktoWalkEdgesWalkEdgesincorrectly returned an error when there were only nodes in the graph with no edges.WalkNodesthat walks the nodes. This allows access to nodes with no edges.DOTStringto print nodes without edges.