Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path handling in storagegit #2282

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Fix path handling in storagegit #2282

merged 3 commits into from
Jul 12, 2023

Conversation

bufdev
Copy link
Member

@bufdev bufdev commented Jul 11, 2023

  • All paths should have storageutil.Validate{Path,Prefix} called on them at the entrypoint.
  • ExternalPath being used potentially incorrectly here, it's a gray area, changing to Path for now.
  • A few other normalization fixes.

@@ -180,10 +187,11 @@ func (b *bucket) walkTree(
return nil
}

// path is expected to be normalized by calling cunrions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in comment.

@bufdev bufdev merged commit 1986493 into main Jul 12, 2023
@bufdev bufdev deleted the storagegit-fixes branch July 12, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants