Clean up storage.PutOptions #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkwarren
reviewed
Nov 15, 2023
| // This is a suggestion, implementations may choose to ignore this option. | ||
| func PutWithSuggestedChunkSize(suggestedChunkSize int) PutOption { | ||
| return func(putOptions *putOptions) { | ||
| putOptions.suggestedChunkSize = &suggestedChunkSize |
There was a problem hiding this comment.
Should we ignore negative values here?
| } | ||
|
|
||
| func (p *putOptions) SuggestedDisableChunking() bool { | ||
| return p.suggestedChunkSize != nil && *p.suggestedChunkSize == 0 |
There was a problem hiding this comment.
If we don't prevent negative values we should change the conditional from == to <= here.
pkwarren
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an interface so these can only be built by the
storagepackage, clean up docs, clean up meaning of 0.