Delete PLUGIN_REGISTRY_TYPE_ARCHIVE #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfridman
reviewed
Mar 27, 2024
| PLUGIN_REGISTRY_TYPE_UNSPECIFIED = 0; | ||
| PLUGIN_REGISTRY_TYPE_GO = 1; | ||
| PLUGIN_REGISTRY_TYPE_NPM = 2; | ||
| PLUGIN_REGISTRY_TYPE_MAVEN = 3; | ||
| PLUGIN_REGISTRY_TYPE_SWIFT = 4; | ||
| PLUGIN_REGISTRY_TYPE_PYTHON = 5; | ||
| PLUGIN_REGISTRY_TYPE_ARCHIVE = 6; |
There was a problem hiding this comment.
The only time we would need this is if we want a default plugin option for a given plugin against the archive registry. Otherwise some plugins may not work out-of-the-box.
If we don't care about this property, then this makes sense.
There was a problem hiding this comment.
Not sure what you mean here - I think this enum is denoting what package ecosystem something is a part of, is there something else it should represent?
There was a problem hiding this comment.
Ah, you only removed the enum, not the archive registry config.
There was a problem hiding this comment.
I also removed that, just now, but still not sure what you mean
mfridman
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All plugins can be used with archives.