Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't rely on global rand #17

Merged
merged 3 commits into from
Jun 7, 2023
Merged

Don't rely on global rand #17

merged 3 commits into from
Jun 7, 2023

Conversation

jhump
Copy link
Member

@jhump jhump commented Jun 7, 2023

No description provided.

@jhump jhump requested a review from jchadwick-buf June 7, 2023 21:33
@jhump jhump mentioned this pull request Jun 7, 2023
Merged
jchadwick-buf
jchadwick-buf approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@jchadwick-buf jchadwick-buf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unenthused about needing to copy all of this standard library code just to avoid using the global randomizer, but I already know there's not another way to do this, so if that's what we have to do, I can't see any way to make this better.

@jchadwick-buf jchadwick-buf merged commit 598cca8 into jchadwick/roundrobin Jun 7, 2023
@jchadwick-buf jchadwick-buf deleted the jh/no-global-rand branch June 7, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchadwick-buf jchadwick-buf jchadwick-buf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhump @jchadwick-buf