Eliminate test flakes in recently-added heap tests #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps the sift up/down ops inside the heap impl are not entirely deterministic? It seemed rather consistent in my tests, and has mostly been true in CI. And yet there were also these two failures 🤔:
https://github.com/bufbuild/httplb/actions/runs/8754637253/job/24026890423
https://github.com/bufbuild/httplb/actions/runs/8755567093/job/24029992149
So this adjusts the test to not care about precise order. Instead, it only cares about distinctness of the items picked.
Edit: source of non-determinism was use of a map inside the implementation of
update
, nothing to do with any non-determinism in the container/heap package.