Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin request for Buf Schema Registry [protoc-gen-openapi] #821

Closed
nadilas opened this issue Sep 16, 2023 · 3 comments · Fixed by #844
Closed

Plugin request for Buf Schema Registry [protoc-gen-openapi] #821

nadilas opened this issue Sep 16, 2023 · 3 comments · Fixed by #844
Labels
Feature New feature or request

Comments

@nadilas
Copy link

nadilas commented Sep 16, 2023

Mandatory

Where is the source code for the plugin?

Example, the source code for the protoc-gen-connect-go plugin is found here:

https://github.com/google/gnostic/tree/main/cmd/protoc-gen-openapi

Optional

Does the plugin have a valid semver version?

Yes

What is the latest version, and where did you get this value from?

cmd/protoc-json-openapi/v0.6.5

https://github.com/google/gnostic/releases/tag/cmd%2Fprotoc-json-openapi%2Fv0.6.5

Does the plugin have a dependency on another plugin?

Not to my knowledge.

Does the output of this plugin depend on any other external libraries?

Not to my knowledge.

@timburks please correct if necessary

Ref: google/gnostic#365

@nadilas nadilas added the Feature New feature or request label Sep 16, 2023
@mfridman
Copy link
Member

The main blocker for this is a stable tag upstream greater than the current v0.6.9.

Specifically, to make this work with Remote Plugins need to set the output_mode=source_relative introduced in google/gnostic#359.

There are 2 relevant issues upstream:

@jalaziz
Copy link

jalaziz commented Sep 23, 2023

Looks like v0.7.0 was released last month which contains google/gnostic#359.

@mfridman
Copy link
Member

Thanks, we'll prepare a PR and push this through in the next week or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants