Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate off deprecated github action #259

Merged
merged 3 commits into from
Dec 5, 2022
Merged

migrate off deprecated github action #259

merged 3 commits into from
Dec 5, 2022

Conversation

pkwarren
Copy link
Member

@pkwarren pkwarren commented Dec 5, 2022

Migrate from last-successful-commit-action to nx-set-shas. This reflects upstream changes made in tj-actions/changed-files:

tj-actions/changed-files#822

Migrate from last-successful-commit-action to nx-set-shas. This reflects
upstream changes made in tj-actions/changed-files:

tj-actions/changed-files#822
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@mfridman
Copy link
Member

mfridman commented Dec 5, 2022

Do we need to update the permissions as well?

https://github.com/nrwl/nx-set-shas#permissions-in-v2

It says it needs:

    permissions:
      contents: 'read'
      actions: 'read'

Or will these be included by default?

Copy link
Member

@mfridman mfridman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Just one comment wrt permissions.

@pkwarren
Copy link
Member Author

pkwarren commented Dec 5, 2022

I don't think actions are restricted by default on this repo but I can add those in case that is turned on later.

@pkwarren pkwarren merged commit 71ff936 into main Dec 5, 2022
@pkwarren pkwarren deleted the pkw/nx-set-shas branch December 5, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants