update linker tests to have descriptive names #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update linker table driven tests to have descriptive names and run with t.Run (for easier targeting/debugging of a single test). Enable the 'paralleltest' linter which will ensure that all tests can run in parallel and we properly reassign variables inside a loop so they run properly in parallel.
pkwarren
commented
Sep 14, 2022
| @@ -58,7 +58,6 @@ linters: | |||
| - nilerr | |||
| - nilnil | |||
| - nonamedreturns | |||
| - paralleltest | |||
There was a problem hiding this comment.
Enabled every test to run in parallel.
| }, | ||
| { | ||
| map[string]string{ |
There was a problem hiding this comment.
This test was duplicated (same input) as another one above so removed it.
| if tc.errMsg == "" { | ||
| if err != nil { | ||
| t.Errorf("case %d: expecting no error; instead got error %q", i, err) | ||
| assert.Truef(t, strings.HasPrefix(name, expectedPrefix), "expected test name %q to have %q prefix", name, expectedPrefix) |
There was a problem hiding this comment.
This felt nice to enforce some consistency in naming.
| type msg struct { | ||
| pos ast.SourcePos | ||
| text string | ||
| } | ||
| var msgs []msg |
There was a problem hiding this comment.
Moved this into the tests - otherwise it led to a race condition.
Co-authored-by: Joshua Humphries <jhumphries@buf.build>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update linker table driven tests to have descriptive names and run with t.Run (for easier targeting/debugging of a single test). Enable the 'paralleltest' linter which will ensure that all tests can run in parallel and we properly reassign variables inside a loop so they run properly in parallel.