don't treat overflowing octal int as if decimal float #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkwarren
approved these changes
Sep 16, 2022
| for name, tc := range testCases { | ||
| tc := tc | ||
| t.Run(name, func(t *testing.T) { | ||
| handler := reporter.NewHandler(nil) |
There was a problem hiding this comment.
I think you need to call Parallel here for the linter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently landed a patch in protoc to make its handling of extremely large int literals more consistent:
protocolbuffers/protobuf#10555
I came back to protocompile to make sure its behavior was the same, and realized that protocompile had a bug: if an octal integer literal was too large to fit in a uint64, it would end up being parsed as if it were a decimal float 😨.
This fixes that, so its behavior matches the behavior of protoc (as of latest main branch).
Like in previous PR, I also went ahead and updated/reformatted an existing table-driven test so it uses test names and
t.Run.The test case is certain to be easier to review if you look commit-by-commit.