lenient utf8 parser #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of today,
protocallows invalid UTF8. That means that proto sources that are mainly compiled withprotoc(such as the googleapis module) could have bad encoding. And that means that protocompile, at least for now, needs to allow it, too.This makes protocompile work the same way as protoparse: bad encoding bytes are silently replaced with the unicode replacement char. This is how lenient UTF8 decoders are expected to work. This does not match the behavior of
protoc, but this is an acceptable variance for now.This addresses an old bug filed by @amckinney: jhump/protocompile-old#5