validation of fields that may refer to map entry message works without source #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkwarren
approved these changes
Sep 21, 2022
linker/linker_test.go
Outdated
| t.Run(name, func(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| if strings.HasPrefix(name, "fails") { |
pkwarren
approved these changes
Sep 21, 2022
jhump
force-pushed
the
jh/fix-map-validation
branch
from
ac83054
to
b5126c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was logic in here. But I happened to re-read while doing some refactoring in #40 and saw that it was just wrong.
So I added some tests (yay!) as well as some extra conditions to make this check bullet-proof.