Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove over eager struct validation #24

Merged
merged 6 commits into from
Nov 20, 2023
Merged

Remove over eager struct validation #24

merged 6 commits into from
Nov 20, 2023

Conversation

Alfus
Copy link
Contributor

@Alfus Alfus commented Nov 18, 2023

Previously, assumed all "@type" fields in structs indicated a json encoded Any, but these are actually valid json/yaml field names, so should not be treated specially. Instead a real protobuf Any should be used to hold "any value".

@Alfus Alfus requested a review from jhump November 18, 2023 17:54
@Alfus Alfus merged commit 5e7587c into main Nov 20, 2023
5 checks passed
@Alfus Alfus deleted the alfus/dynchecks branch November 20, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants