Python Package #5
Conversation
|
Also, I'm not sure if we should track the autogenerated files. 😅 I think I'll remove them as they don't seem extremely valuable and will cause some noise in the PR diffs. |
|
|
||
| # Compile services | ||
| docker run --rm -v $PWD:$PWD -u 1000 -w $PWD \ | ||
| bufferapp/grpc-docker-python:latest \ |
There was a problem hiding this comment.
There was a problem hiding this comment.
💯 Thanks for creating the issue, happy to switch to the official image if they support 3.6 :D
There was a problem hiding this comment.
Awesome, thanks for the PR!
This process could be automated but it's a bit tricky with 2FA without using service keys.
In the future I think all of this could be automated in a sort of CI/CD pipeline. Will 🔍 a bit more soon!
Yeah this does feel like a perfect application for a proper CI solution. I think ideally you could just push to master and a CI job can take care of building the package and release.
Happy to just use a manual step for now while we're still building things out!
|
|
||
| # Compile services | ||
| docker run --rm -v $PWD:$PWD -u 1000 -w $PWD \ | ||
| bufferapp/grpc-docker-python:latest \ |
There was a problem hiding this comment.
💯 Thanks for creating the issue, happy to switch to the official image if they support 3.6 :D
|
Hey @davidgasquez! Just wanted to mention that I implemented the package in the buda-events-consumer repo, and it was super smooth! |
Hey there @michael-erasmus! Today I spent more time iterating on the idea of publishing the Python package automatically.
With this PR we should be able to run
make package-pythonto produce atar.gzfile ready to be uploaded to the releases Github tab. This process could be automated but it's a bit tricky with 2FA without using service keys. Alternatively, I thought we could just have sub-repositories and we wouldn't need to create and upload thetar.gzfile, just pushing the changes in each repo 😄PS: In the future I think all of this could be automated in a sort of CI/CD pipeline. Will 🔍 a bit more soon!