Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Add star icon #312

Merged
merged 4 commits into from
Jul 27, 2021
Merged

Add star icon #312

merged 4 commits into from
Jul 27, 2021

Conversation

daltino
Copy link
Contributor

@daltino daltino commented Jul 27, 2021

Description

Add star icon

Motivation and Context

It adds the star icon needed for Post Previews in new calendar.

Screenshots (if appropriate):

Star Icon

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style and guidelines of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the CHANGELOG document.
  • I have added tests to cover my changes.
  • I have performed a self-review of my own code
  • I have tested my changes/additions in the latest Chrome, Firefox, and Safari.
  • I have commented my code, particularly in hard-to-understand areas
  • All new and existing tests passed.
  • I have performed the accessibility audit of my UI changes according to the accessibility doc.
  • [Buffer Engineers] Someone from the Design team reviewed and approved my changes
  • [Buffer Engineers] I have notified the BDS team of my changes in the #proj-design-system Slack channel

@daltino daltino requested a review from cmunozgar July 27, 2021 13:40
@daltino daltino self-assigned this Jul 27, 2021
Copy link
Contributor

@cmunozgar cmunozgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @daltino!

One suggestion is to update the Changelog. Beware that I have a pending PR #311 that contains the latest changes to the Changelog. Probably wait till have that PR merged.

And one question that I have is why are there changes to the package.json file?

@hamstu
Copy link
Contributor

hamstu commented Jul 27, 2021

@cmunozgar @daltino The package-lock changes are likely from a different NPM version. NPM 7 changed the lockfile format to v2, and so it will result in a big diff when someone uses a diff. npm version from what was used last in main - if that makes sense.

@daltino
Copy link
Contributor Author

daltino commented Jul 27, 2021

@hamstu @cmunozgar are the changes in the package.lock ok, or I can simply move back to what's on the main branch. I just pulled/merged changes from the main

@daltino daltino merged commit 51632d0 into main Jul 27, 2021
@hamstu
Copy link
Contributor

hamstu commented Jul 27, 2021

Yeah @daltino, it's fine either way I think 👍🏻

@philippemiguet philippemiguet deleted the tasks/icon-star branch June 9, 2023 11:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants