✨ Reencode task for worker #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we really want to do this in the backend?. |
|
Yes and no. I think it makes sense to do this in the frontend too, but I think we should have to option in the backend as well. a) to make sure the file is in the right format and b) to handle cases where the conversion in the frontend is not possible (e.g. files larger than 2GB, browsers without wasm) |
anuejn
reviewed
Apr 4, 2023
|
fair points :) |
|
Ah we probably also need a way to inform the frontend, that the audio file changed. -> Future |
anuejn
approved these changes
Apr 4, 2023
Closed
pajowu
force-pushed
the
pajowu/reencode_worker
branch
3 times, most recently
from
5d35a14
to
801d3e8
Compare
anuejn
reviewed
May 8, 2023
rroohhh
requested changes
May 9, 2023
pajowu
force-pushed
the
pajowu/reencode_worker
branch
from
801d3e8
to
186c0bd
Compare
pajowu
force-pushed
the
pajowu/reencode_worker
branch
from
186c0bd
to
4c1af0a
Compare
pajowu
force-pushed
the
pajowu/reencode_worker
branch
from
4c1af0a
to
5d8722f
Compare
rroohhh
approved these changes
May 15, 2023
rroohhh
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reencode everything to 128k cbr mp3 and m4a