Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test case for ZeroDivisionError #6

Merged
merged 3 commits into from
Dec 27, 2014

Conversation

tgalery
Copy link
Contributor

@tgalery tgalery commented Dec 12, 2014

This adds a test case with a vector full of zeros to show that tests break.

@tgalery tgalery mentioned this pull request Dec 12, 2014
@tgalery
Copy link
Contributor Author

tgalery commented Dec 22, 2014

@bugra we decided to smooth outside calls to your library. If you want to keep these little refactor of the tests, feel free to merge. I'm gonna close the corresponding issue. In any event, it would be great to spin a new release and upload to clojars. The last one there throw some weird warnings.

@tgalery tgalery changed the title Test case with zero vector Test case for ZeroDivisionError Dec 22, 2014
bugra added a commit that referenced this pull request Dec 27, 2014
@bugra bugra merged commit 76689ed into bugra:master Dec 27, 2014
@bugra
Copy link
Owner

bugra commented Dec 27, 2014

@tgalery Incremented the version number by 1 and pushed the clojars. Thanks for the test case!

@tgalery
Copy link
Contributor Author

tgalery commented Dec 29, 2014

Thanks for this!

On Sat, Dec 27, 2014 at 8:10 PM, Bugra Akyildiz notifications@github.com
wrote:

@tgalery https://github.com/tgalery Incremented the version number by 1
and pushed the clojars. Thanks for the test case!


Reply to this email directly or view it on GitHub
#6 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants