Fix middleware panic on nil *http.Request #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DariaKunoichi
force-pushed
the
daria-PLAT-11611
branch
from
73c79aa
to
e6c189a
Compare
tomlongridge
approved these changes
Feb 20, 2024
DariaKunoichi
force-pushed
the
daria-PLAT-11611
branch
from
f382227
to
c4272c2
Compare
Merged
DariaKunoichi
added a commit
that referenced
this pull request
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
One of the two default OnBeforeNotify callbacks was panicking if http request in Event's RawData was nil.
Check for nil request added (#210).
Design
Changeset
Added check for nil http.Request in
httpRequestMiddlewarecallback.Testing
Added unit tests for nil request scenario.