Fetch code from files before changing the file path #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we made file paths that matched the project root relative, which then could only be resolved from the PWD Now we fetch the code before trimming the project root, so that we are using the absolute path to the file and can find things that are outside of the PWD
kattrali
approved these changes
Dec 3, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Currently we trim the project root from file names before fetching the code for the file. This breaks if the file we want is in the project root, but not in the PWD (see #245)
To fix this, we will now fetch the code using the absolute path of the file
Changeset
.github/workflows/python-package.ymldisable fail-fast as it can hide failures (e.g. if Python 3.5 fails, 3.6 will be cancelled and so you can't tell if it passes)
bugsnag/event.pyFetch the code before (potentially) removing the project root from the file path
tox.iniInstall compatible version of
pytest-djangoon Django < 2.2 (see v4.0.0 changelog). I'm not sure why this now requiressixto be installed explicitly when it didn't before though :/Testing
One of the existing tests actually covered this case, it just didn't assert on the code
I also manually tested this before & after with the repro case in #245: