This repository has been archived by the owner on Jan 12, 2021. It is now read-only.
fix: Fix error handling logic for missing res param #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a synchronous error happens, or an async error before there is an HTTP response object, the existing logic would throw an error "Cannot read property 'statusCode' of undefined". This fix only accesses the res property if it exists.
Cawllec
approved these changes
Dec 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a synchronous error happens, or an async error before there is an HTTP response object, the
existing logic would throw an error "Cannot read property 'statusCode' of undefined". This fix only
accesses the res property if it exists.