add github actions unit test workflow #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djskinner
commented
Nov 10, 2021
| runs-on: ubuntu-20.04 | ||
| strategy: | ||
| matrix: | ||
| node: [4, 6, 8, 10, 12, 14] |
There was a problem hiding this comment.
I included 10, 12 and 14.
Worth noting the output on 14 includes lots of warnings of the form: Warning: Accessing non-existent property 'cd' of module exports inside circular dependency. I believe this because node 14 doesn't allow circular imports anymore.
It's possibly caused by a dev dependency that needs updating but not clear which.
There was a problem hiding this comment.
It's possibly caused by a dev dependency that needs updating but not clear which.
Looks like it's eslint or one of their dependencies since it only happens in the lint step
I think it's fine to leave it as-is or even remove eslint entirely — we don't really change this repo so I don't think linting is important
imjoehaines
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.