Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: Avoid double-set of communication parameters on Open #174

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Feb 16, 2024

This PR removes a useless double-call to setCommState on Windows nativeOpen implementation.
The double setCommState (even if theoretically should not) has some side effects on some microcontroller boards.

Copy link
Collaborator

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

@cmaglie cmaglie merged commit 9a2045a into master Feb 16, 2024
8 checks passed
@cmaglie cmaglie deleted the windows-multi-set-rtscts branch February 16, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants