Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tornado 6 support #248

Closed
bugy opened this issue Dec 26, 2019 · 1 comment
Closed

Add tornado 6 support #248

bugy opened this issue Dec 26, 2019 · 1 comment
Labels
feature resolved
Milestone
1.15.0

Comments

@bugy
Copy link
Owner

bugy commented Dec 26, 2019

It the moment, Script server requires Tornado 5 module. However, tornado 6 is available for a long time already and this is the default version on most distributions.
To make users life easier, Tornado 6 support should be added
@bugy bugy added the feature label Dec 26, 2019
@bugy bugy added this to the 1.15.0 milestone Dec 26, 2019
bugy added a commit that referenced this issue Dec 29, 2019
@bugy
#248 added tornado 6 to supported versions
4814678
@bugy bugy added the resolved label Dec 29, 2019
@bugy
Copy link
Owner Author

bugy commented Dec 29, 2019

I tested it and it seems to be working. So I just updated the documentation and the requirements file

bugy added a commit that referenced this issue Dec 29, 2019
@bugy
#248 fixed client proxy tests for tornado 6
2432347
@bugy bugy closed this as completed Feb 1, 2020
antonellocaroli pushed a commit to antonellocaroli/script-server that referenced this issue Aug 1, 2020
@bugy @antonellocaroli
bugy#248 added tornado 6 to supported versions
e4c6adc
antonellocaroli pushed a commit to antonellocaroli/script-server that referenced this issue Aug 1, 2020
@bugy @antonellocaroli
bugy#248 fixed client proxy tests for tornado 6
d337575
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature resolved
Projects
None yet
Milestone
1.15.0
Development

No branches or pull requests
1 participant
@bugy