Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility for normal users to view script logs #249

Closed
bugy opened this issue Dec 26, 2019 · 1 comment
Closed

Add possibility for normal users to view script logs #249

bugy opened this issue Dec 26, 2019 · 1 comment

Comments

@bugy
Copy link
Owner

bugy commented Dec 26, 2019

At the moment, script logs are available for admins only. So sometimes (e.g. #230 #178) admin access is given to everyone just to view the logs

Since the introduction of #127 feature, admin access should be used only for real admins, because they will have access to script and configuration internals.

To keep the possibility for users to read logs, after making them non-admins, there should be a feature in the main interface to view logs (history).
By default, it should allow users to view their own executions.
And there should be a possibility to give some users access to all logs

@bugy bugy added the feature label Dec 26, 2019
@bugy bugy added this to the 1.15.0 milestone Dec 26, 2019
@bugy
Copy link
Owner Author

bugy commented Dec 29, 2019

Done, now all the users would be able to see their own execution history

Admins will be able to see full history (own execution and of other users)

Or you can give full history access, without admin rights:

  "access": {
    "full_history": [
      "user1", 'user2", "@my_group"
    ]
  }

Those users will see the full history in the normal user interface, but won't be able to access the admin page

@bugy bugy added the resolved label Dec 29, 2019
@bugy bugy closed this as completed Feb 1, 2020
antonellocaroli pushed a commit to antonellocaroli/script-server that referenced this issue Aug 1, 2020
antonellocaroli pushed a commit to antonellocaroli/script-server that referenced this issue Aug 1, 2020
antonellocaroli pushed a commit to antonellocaroli/script-server that referenced this issue Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant