Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor same_arg_param and repeat_param #398

Closed
bugy opened this issue Feb 14, 2021 · 1 comment
Closed

Refactor same_arg_param and repeat_param #398

bugy opened this issue Feb 14, 2021 · 1 comment

Comments

@bugy
Copy link
Owner

bugy commented Feb 14, 2021

At the moment these 2 settings have reverse meaning, this should be fixed

@bugy bugy added the bug label Feb 14, 2021
@bugy bugy added this to the 1.17.0 milestone Mar 26, 2021
bugy added a commit that referenced this issue Mar 29, 2021
@bugy
Copy link
Owner Author

bugy commented Mar 29, 2021

Fixed. I did the following changes:

  • same_arg_param: now "removes a whitespace" between param and value (e.g. -flag=value)
  • repeat_param: removed, in favor of new multiselect_argument_type
  • multiple_arguments: removed, in favor of new multiselect_argument_type
  • multiselect_argument_type: NEW. Can be used for multiselect only. The value should be one of:
    • single_argument (default): sends all the values as a single argument, separated by separator (-param value1,value2,value3)
    • argument_per_value: sends every value as a separate argument (-param value1 value2 value3)
    • repeat_param_value: sends every value as a separate argument and repeat param for each value (-param value1 -param value2 -param value3)

These changes should be applied automatically to existing configs via a migration (run on server startup)

@miksir FYI. Hopefully I won't break anything for your setup

@bugy bugy added the resolved label Mar 29, 2021
@bugy bugy closed this as completed Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant