Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link broken in runners, crash SC at start #546

Closed
father-mande opened this issue Apr 2, 2022 · 2 comments
Closed

link broken in runners, crash SC at start #546

father-mande opened this issue Apr 2, 2022 · 2 comments

Comments

@father-mande
Copy link

Hi,
I use link in runners folder to different scripts in different places.
If a link is broken (target was removed) SC crash at start ... reason file not exist.
===========
Traceback (most recent call last):
File "launcher.py", line 11, in
main.main()
File "src/main.py", line 79, in main
migrations.migrate.migrate(TEMP_FOLDER, CONFIG_FOLDER, SERVER_CONF_PATH, LOG_FOLDER)
File "src/migrations/migrate.py", line 387, in migrate
migration_descriptor.callable(context)
File "src/migrations/migrate.py", line 269, in __migrate_bash_formatting_to_output_format
for (conf_file, json_object, content) in _load_runner_files(context.conf_folder):
File "src/migrations/migrate.py", line 348, in _load_runner_files
content = file_utils.read_file(conf_file)
File "src/utils/file_utils.py", line 63, in read_file
with open(path, mode, newline=newline) as f:
FileNotFoundError: [Errno 2] No such file or directory: 'conf/runners/xxxxxxx.json'
==========
Is it possible to replace crash by a log message / warning or ignore it (even using a new parameter for launcher.py ?

for the moment, I work around using a shell to verify all link in runners before launching SC.

Philippe.

@bugy bugy added this to the 1.18.0 milestone Apr 4, 2022
@bugy
Copy link
Owner

bugy commented Apr 4, 2022

Hi @father-mande thx for reporting. I added a quick fix, which ignores broken symlinks during migration.

@father-mande
Copy link
Author

Hi,

Thanks for so quick response, I will test it (even I am sure it's correct ...)

Best regards.
Philippe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants