Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule repeat end date / execution count #676

Closed
UrekD opened this issue Jun 9, 2023 · 5 comments
Closed

Schedule repeat end date / execution count #676

UrekD opened this issue Jun 9, 2023 · 5 comments

Comments

@UrekD
Copy link
Contributor

UrekD commented Jun 9, 2023

Hey,

For scheduling repeatable task it would be nice to have extra options to specify when the task should stop/not be executed anymore or how many times a task should execute.

For I instance I reworked the current repeatable option to require the end time to satisfy our needs as:
image

I'm open to working on a proper implementation, but I'd need someone to do the frontend, as I'm terrible with that.

@bugy
Copy link
Owner

bugy commented Jun 9, 2023

Hi @UrekD great idea, thanks. Feel free to submit PR for backend.
You can try to do frontend too, it should be pretty simple in this case. I could tell you which classes are affected

@bugy bugy added the feature label Jun 9, 2023
@UrekD
Copy link
Contributor Author

UrekD commented Jun 10, 2023

Hi @UrekD great idea, thanks. Feel free to submit PR for backend. You can try to do frontend too, it should be pretty simple in this case. I could tell you which classes are affected

Hey @bugy, yeah I figured it would be much easier to edit the vue and build it than the manual js editing I did like an idiot before xD

After managing to get it to build on windows, I managed to construct the box shown below.

brave_dpBB3Fl6x2

If you are happy with the structure of that I'll move onto the functional part. As you can see the styling is not good with that, if there is an easy way to handle that I'd appreciate that. The yet unformatted additions can be found here.

@bugy
Copy link
Owner

bugy commented Jun 11, 2023

Looks very good to me! If you struggle too much with styling, you can leave it for me

@UrekD
Copy link
Contributor Author

UrekD commented Jun 12, 2023

Minor bug the date field is not required, so user can sent it empty as it just grabs the default value.

image

@UrekD
Copy link
Contributor Author

UrekD commented Jun 12, 2023

Looks very good to me! If you struggle too much with styling, you can leave it for me

Ah I thought the styling was dynamic not static, in this case I got it.

brave_XAUBlsHBCw

I think I got the functionality down I'll give it a day or 2 test then open merge 😄

bugy added a commit that referenced this issue Jul 10, 2023
Extend repeat schedule functionality #676
@UrekD UrekD closed this as completed Jul 10, 2023
@bugy bugy added the resolved label Aug 4, 2023
@bugy bugy added this to the 1.18.0 milestone Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants