Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change c.std value to standard c99 #11

Merged
merged 1 commit into from
May 31, 2024
Merged

Change c.std value to standard c99 #11

merged 1 commit into from
May 31, 2024

Conversation

wroyca
Copy link
Contributor

@wroyca wroyca commented May 26, 2024

Closes #10

Looking at the source, they use proper #define to manage with and/or without GNU extension

CI

@Klaim Klaim requested a review from Swat-SomeBug May 26, 2024 20:16
@helmesjo
Copy link

@boris-kolpackov Is this good to go? Looked quickly and there are a few warnings that probably should be taken care of, but they seem unrelated to this PR anyways:

warning: multiple files are distributed as redist/glfw-3.3.8/src/context.c
  info: second file is dist/glfw-3.3.8/src/context.c
  info: this warning will become error in the future

@wroyca
Copy link
Contributor Author

wroyca commented May 28, 2024

@boris-kolpackov Is this good to go? Looked quickly and there are a few warnings that probably should be taken care of, but they seem unrelated to this PR anyways:

warning: multiple files are distributed as redist/glfw-3.3.8/src/context.c
  info: second file is dist/glfw-3.3.8/src/context.c
  info: this warning will become error in the future

but they seem unrelated to this PR anyways:

They are indeed unrelated, so I opted to leave them as-is for this PR 👍

Copy link
Collaborator

@Swat-SomeBug Swat-SomeBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

@boris-kolpackov
Copy link

Looks good to me. Someone just needs to merge this and release and publish a revision.

@Swat-SomeBug Swat-SomeBug merged commit ff500d9 into build2-packaging:master May 31, 2024
16 checks passed
@boris-kolpackov
Copy link

@Swat-SomeBug Thanks for merging and releasing the 3.3.8+1 revision! It is now published to the testing section of cppget.org: https://cppget.org/glfw/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

c.std=gnu99 cannot be used with MSVC
4 participants