Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to Mirakle #187

Closed
wants to merge 1 commit into from
Closed

Add link to Mirakle #187

wants to merge 1 commit into from

Conversation

skrugly
Copy link
Contributor

@skrugly skrugly commented Feb 13, 2018

Apart from current Mainframer functionality Mirakle is highly extendable thanks to Gradle plugin system and supports remote project dir replacement described here.

@artem-zinnatullin
Copy link
Contributor

Hey @Adambl4,

We definitely appreciate more native integration of Mainframer with Gradle, the only problem atm is that we'd like to keep Mainframer itself as both a standard and a reference implementation for couple reasons:

  • It allows us add new features without need in repeating them in other implementations
  • It keeps things more consistent in the community (here I'm referencing to custom Gradle DSL that Miracle provides)

Mirakle implements Mainframer standard in a way that you support Mainframer config files which is really great 👍, however as we add more features like #188 or #182 Mirakle will have to basically duplicate them internally which might result in different behavior, bugs and other ways of inconsistency (+ it's just more work for you)

It would be super great if you could call Mainframer instead of ssh/rsync in Mirakle so it would implement both native Gradle integration as well as all the features we bundle into Mainframer itself! (you could add a parameter for path of Mainframer executable)

What do you think?


There is a small chance that because of deeper integration with system like Gradle you'll be able to make sync more effective, but as I was thinking about it for quite some time I wasn't able to convince myself that it'll be the case in real life

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants