Fix samples/mvn/README.md after #185 #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After introducing buildfoundation#185 mainframer is a system wide command -- updating readme of mvn sample.
artem-zinnatullin
approved these changes
Oct 15, 2018
|
Will you merge it @artem-zinnatullin ? |
|
Waiting for @ming13 review :) We have same @ming13 I think it's good time for us to start migrating basic docs to 3.x (see #207), we can point people on 2.x tags or 2.x branch if they need docs for 2.x, most of the docs are backwards/forward compatible anyway |
|
Alright, gonna merge this and update the remaining examples This particular change is not really breaking for the documentation as it just shows how to run something with Mainframer and could have been true with 2.x if user has an alias |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After introducing #185 mainframer is a system wide command -- updating readme of mvn sample.